Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.1] Fixes PHP syntax highlighting in BBCode under PHP 8.3 #8265

Merged
merged 1 commit into from
Jun 30, 2024
Merged

[2.1] Fixes PHP syntax highlighting in BBCode under PHP 8.3 #8265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Sources/Subs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3987,9 +3987,12 @@ function highlight_php_code($code)
error_reporting($oldlevel);

// Yes, I know this is kludging it, but this is the best way to preserve tabs from PHP :P.
$buffer = preg_replace('~SMF_TAB(?:</(?:font|span)><(?:font color|span style)="[^"]*?">)?\\(\\);~', '<pre style="display: inline;">' . "\t" . '</pre>', $buffer);
$buffer = preg_replace('~SMF_TAB(?:</(?:font|span)><(?:font color|span style)="[^"]*?">)?\(\);~', '<span style="white-space: pre-wrap;">' . "\t" . '</span>', $buffer);

return strtr($buffer, array('\'' => '&#039;', '<code>' => '', '</code>' => ''));
// PHP 8.3 changed the returned HTML.
$buffer = preg_replace('/^(<pre>)?<code[^>]*>|<\/code>(<\/pre>)?$/', '', $buffer);

return strtr($buffer, ['\'' => '&#039;']);
}

/**
Expand Down
Loading