Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove menu item if all submenu items are disabled #7733

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

sbulen
Copy link
Contributor

@sbulen sbulen commented Apr 22, 2023

Fixes #7559

This occurs if all submenu items are disabled. You get a weird submenu list, and an error in the error log.

BEFORE... You can see that all submenu items were disabled via permissions.
label_issue_1
label_issue_3

AFTER...
label_issue_4

@sbulen sbulen added this to the 2.1.5 milestone Apr 22, 2023
@sbulen sbulen requested a review from live627 April 22, 2023 21:03
@live627 live627 merged commit d0850e9 into SimpleMachines:release-2.1 Jul 12, 2023
@live627
Copy link
Contributor

live627 commented Jul 12, 2023

which app you use to view the array like that?

@sbulen
Copy link
Contributor Author

sbulen commented Jul 12, 2023

That's a screenshot from the Eclipse php step debugger. Using xdebug.

@sbulen sbulen deleted the submenu_check branch July 16, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8: Undefined index: label, xxx/Themes/default/GenericMenu.template.php (Line 121)
3 participants