Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 391 manuly update scroll offset #393

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bawantha
Copy link

@bawantha bawantha commented Jul 24, 2024

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@bawantha bawantha changed the title Fix/issue 361 mannuly update scroll offset Fix/issue 391 manuly update scroll offset Jul 24, 2024
@ParthBaraiya ParthBaraiya linked an issue Sep 13, 2024 that may be closed by this pull request
@@ -462,6 +462,11 @@ class WeekViewState<T extends Object?> extends State<WeekView<T>> {

// Update builders and callbacks
_assignBuilders();

if (widget.scrollOffset != oldWidget.scrollOffset) {
_lastScrollOffset = widget.scrollOffset;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be like following,

_lastScrollOffset = widget.scrollOffset ??
widget.startDuration.inMinutes * widget.heightPerMinute;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually update the weekView scrollOffset
2 participants