Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intake subsystem to RobotContainer.java #60

Merged
merged 6 commits into from
Jan 6, 2024

Conversation

HoodieRocks
Copy link
Contributor

@HoodieRocks HoodieRocks commented Jan 6, 2024

Description

This pull request adds the intake subsystem to the robot container, allowing the intake to be used.

Scoring states have also been updated to be publicly accessible

Fixes #53

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if any
  • My changes generate no new warnings
  • I have performed tests that prove my fix is effective or that my feature works, if necessary
  • New and existing unit tests pass locally with my changes

@IanTapply22 IanTapply22 added the enhancement New feature or request label Jan 6, 2024
@IanTapply22 IanTapply22 added this to the New Functionality milestone Jan 6, 2024
@IanTapply22 IanTapply22 linked an issue Jan 6, 2024 that may be closed by this pull request
@HoodieRocks HoodieRocks marked this pull request as ready for review January 6, 2024 01:43
Copy link
Member

@IanTapply22 IanTapply22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of issues that need to be fixed but other than that LGTM. Just re-request my review and I'll merge this once they are fixed.

src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
Copy link
Member

@IanTapply22 IanTapply22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IanTapply22 IanTapply22 merged commit 7dc84b0 into 2024-beta Jan 6, 2024
2 checks passed
@IanTapply22 IanTapply22 deleted the 53/add-intake-to-robot-container branch January 6, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Intake Subsystem to Robot Container
2 participants