Skip to content

IOT_DS-8449 Refactor code convention check#60

Open
AndrasZiegler wants to merge 1 commit intomasterfrom
IOT_DS-8449-update-code-convention-workflow
Open

IOT_DS-8449 Refactor code convention check#60
AndrasZiegler wants to merge 1 commit intomasterfrom
IOT_DS-8449-update-code-convention-workflow

Conversation

@AndrasZiegler
Copy link
Contributor

@AndrasZiegler AndrasZiegler commented Jan 26, 2026

Description

Related Issue

Closes #<issue_number>

Changes Made

Checklist

Screenshots (if applicable)

Additional Notes


Note

Medium Risk
CI behavior changes (trigger conditions and a new external action dependency) could alter when/what gets checked and may affect enforcement reliability, though no product/runtime code paths change.

Overview
Simplifies the 00-Check-Code-Convention GitHub Actions workflow by switching from an in-repo/submodule pre-commit + toolchain install/run sequence to a single SiliconLabsSoftware/devs-coding-convention-tool@master action step.

The workflow is now triggered only for PRs targeting main/master/release/** (no longer on most push events), and the workflow_dispatch default branch input is changed from master to main. Also includes minor comment typo fixes in the create_bl_files.{bat,sh} scripts.

Written by Cursor Bugbot for commit dbe91d4. This will update automatically on new commits. Configure here.

@AndrasZiegler AndrasZiegler requested a review from a team as a code owner January 26, 2026 09:56
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2474189c00

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@AndrasZiegler AndrasZiegler changed the title chore: remove .github/coding-convention-tool submodule IOT_DS-8449 Refactor code convention check Jan 26, 2026
@AndrasZiegler
Copy link
Contributor Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73f5e9b279

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@AndrasZiegler AndrasZiegler force-pushed the IOT_DS-8449-update-code-convention-workflow branch 2 times, most recently from b812356 to 4ff0fb1 Compare February 4, 2026 08:15
Code convention workflow now uses github composite action

Co-authored-by: Cursor <cursoragent@cursor.com>
@AndrasZiegler AndrasZiegler force-pushed the IOT_DS-8449-update-code-convention-workflow branch from 4ff0fb1 to dbe91d4 Compare February 6, 2026 07:03
@AndrasZiegler
Copy link
Contributor Author

PR is ready @silabs-TiborL

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants