Updating cat uri to new standards
#18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this issue a while back, calling the
catendpoint as/api/v0/cat/<cid>leads to a 405 response and should be updated as/api/v0/cat?arg=<cid>as mentioned in the documentation.The actual error message
[ipfs-mini] status 405: /api/v0/cat/ is an undocumented behavior, use /api/v0/cat?arg= instead
Also, it seems as request to the
catendpoint is nowPOSTand notGETanymore.Side note
I didn't spend too much time on this PR and some tests fail or hang but this seems to be because either my setup is wrong or because they are outdated (similar effect on master branch). In any case,
catandcatJSONtests passed successfully.