-
-
Notifications
You must be signed in to change notification settings - Fork 184
feat: Assign a unique identifier to all notification updates #2265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Captured feedback from superceded PR:
|
@tkurki I will leave it in the current location until it is determined that it should move elsewhere.
If you are refering to a delta Update with multiple paths, then yes the
Agreed. The current terms used try to align with the current use of ALARM_METHOD, ALARM_STATE in Notifications but clearly there needs to be some more work on this. |
|
@tkurki Have updated terminology to be more conistent and updated both code and docs to align noting that:
Terminology Used:
|
|
@tkurki Have added SQLite store to persist notification identifiers so I guess we now have a NodeJS v22 requirement! |
(Supercedes #2172) The first step on the journey to a full featured Notification API enabling centralised alert management, this PR seeks to:
referencefor performing actionsstatusattribute to a notificationvalueto indicate the:Scope
registerDeltaInputHandlerto inspect all incoming deltaUpdatesreceived by the serverpathstarting withnotifications.are separated into their own Update$source,contextandpathcombination. Assign it to a new:notificationIdidstatusattribute to generated notification value to indicate the available actions and actions taken.statuswith NMEA status attributes/signalk/v2/api/notifications(ref: #1560)
Example: