refactor(security): convert tokensecurity.js to TypeScript #2262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the token security module from JavaScript to TypeScript with full type annotations: - Add TypeScript interfaces for internal data structures (SKRequest, Principal, JWTPayload, LoginResponse, etc.) - Reuse existing types from security.ts and @signalk/server-api - Convert imports from require to ES module syntax - Add type annotations to all functions and parameters - Install @types/jsonwebtoken, @types/bcryptjs, @types/cookie-parser - Maintain CommonJS module.exports for backward compatibility Bug fixes discovered during conversion: - Fix setPassword: was using array index with string (users[username]) instead of .find() - would have crashed on any password change - Fix requestedPermissions: now correctly stores as string per Device interface (was storing boolean, violating type contract) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supercedes the closed PR #2205.
Convert the token security module from JavaScript to TypeScript with full type annotations:
Bug fixes discovered during conversion: