Allow multiple fields in value_count #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frack113
approved these changes
Dec 10, 2024
insdami
reviewed
Dec 10, 2024
| @@ -185,9 +185,20 @@ | |||
| }, | |||
| { | |||
| "field": { | |||
There was a problem hiding this comment.
shouldn't the name indicate that it can contain multiple values? As in fields?
There was a problem hiding this comment.
I agree, but it would require changing all the existing rules. Perhaps both could be accepted?
insdami
reviewed
Dec 10, 2024
| @@ -386,6 +386,8 @@ Counts values in a field defined by `field`. | |||
| The resulting query must count field values separately for each group specified by group-by. | |||
| The condition finally defines how many values must occur to generate a search hit. | |||
|
|
|||
| When you use multiple values in `field` they are linked by an **AND**. | |||
There was a problem hiding this comment.
Would it help to add a snippet to showcase multiple fields?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
value_countrules, it can be useful to count the number of different field value tuples (such as(TargetDomainName, TargetUserName)to represent a user).pySigmaalready accepts a list of strings forcondition.field.After discussion with @frack113 , this PR adds a sentence to state the expected behavior when providing multiple fields in
condition.field. It also updates the correlation rules schema.