Implement Correlation rules log source condition #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than return false for all Correlation rules, change the behavior of the log source condition pipeline to check each of the rules referenced in the Correlation rule and test their logsources. The logsource must fully match one or more of those rules in order to return true. This implementation operates recursively, checking rules that are nested within correlated Correlation rules.
kelnage
changed the title
|
Great! Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than return false for all Correlation rules, change the behavior of the log source condition transformation to check each of the rules referenced in the Correlation rule and test their log sources for a match. The log source must fully match one or more of those rules in order to return true.
This implementation operates recursively, checking rules that are nested within correlated Correlation rules, with early termination if any of the rules match.
This was inspired by this discussion in the SigmaHQ Discord, based on @thomaspatzke's suggested solution.