Regex anime

[BKSteve]

adjust the old deprecated HorribleSubs to a more generic with - between show and absolute episode number

Summary by CodeRabbit

• Refactor
  • Updated the regex pattern for parsing anime release names to enhance accuracy and flexibility.
  • Modified the identifier for the regex pattern related to identifying release groups.
  • Enhanced the show name parsing functionality.
  • Enforced a stricter format for the air date field.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent updates involve refining regex patterns in regexes.py for better parsing of anime-related data and a method renaming in tests/test_snatch.py to enhance clarity in method functionality. These changes aim to increase parsing accuracy and improve code readability.

Changes

File Path	Change Summary
sickchill/oldbeard/name_parser/regexes.py	Updated regex patterns for release groups, show names, and air dates to improve parsing accuracy.
tests/test_snatch.py	Renamed method _fake_is_active to readonly_fake_is_active to clarify its functionality.
pyproject.toml	Updated pytest configuration by commenting out addopts and adding filterwarnings for better control.

🌟🐇💻
In the land of code, where the rabbits hop,
A tiny change, a giant leap in the script shop.
Regex refined, with patterns so bright,
Names parsed just right, in the moon's light.
A method renamed, clarity gained,
In the tests where the digital bunnies trained.
🌟🐇💻

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 88befc9 and 2d6a80f.

Files selected for processing (1)

• sickchill/oldbeard/name_parser/regexes.py (1 hunks)

Additional comments: 1

sickchill/oldbeard/name_parser/regexes.py (1)

• 220-223: The regex pattern update from "HorribleSubs" to a more generic ".+?" pattern and the renaming of the identifier from "anime_horriblesubs" to "anime_ultimate-abs" aligns with the PR objectives to enhance flexibility in parsing anime release names. This change should indeed make the pattern more inclusive and adaptable to various naming conventions. However, it's crucial to ensure that the new pattern does not introduce any unintended matches due to its broad nature. Testing with a diverse set of anime release names is recommended to verify the pattern's effectiveness and to ensure it does not produce false positives.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 2d6a80f and 76c27d2.

Files selected for processing (1)

• sickchill/oldbeard/name_parser/regexes.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• sickchill/oldbeard/name_parser/regexes.py

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 76c27d2 and cbbfb73.

Files selected for processing (1)

• sickchill/oldbeard/name_parser/regexes.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• sickchill/oldbeard/name_parser/regexes.py

[github-actions]

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[BKSteve]

Keep it going

[stale]

This issue has now been unmarked as "stale"

[BKSteve]

date format check change to 4 digit year, with 1 or 2 digit month and day just to allow a little flexibility if they come back with single digit values.

This enables shows with YYYY MM DD to be recognised when not previously if the show name had a YYYY string as part of the name.
After.Midnight.2024.2024.04.10.Joel.Kim.Booster.1080p.HEVC.x265 would fail with prior configuration of regex with update it correctly passes show name and date.

[github-actions]

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[stale]

This issue has now been unmarked as "stale"

[github-actions]

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.