Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renterd): config fields blank sia central #767

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Oct 7, 2024

  • Fixed an issue where configured settings would show as blank when the Sia Central API (used for network averages) was down. Autopilot settings are not visible in UI when Siacentral API is down renterd#1601
  • Fixed an issue where SiacoinField was depending on the siaCentral setting rather than the active exchange rate API.
  • Refactoring
    • Refactored the internal autopilotInfo usage to be more clear.
    • Refactored useResources and resources into one file.

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 9:32pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 9:32pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 9:32pm
hostd ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 9:32pm
website ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 9:32pm

Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: d6b71d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
renterd Patch
@siafoundation/design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexfreska alexfreska force-pushed the fix_renterd_config_fields_blank_sia_central branch from 528e5f4 to 74c1d78 Compare October 7, 2024 18:39
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@telestrial telestrial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the change correctly: do we currently tell the user that the API is down? They may have expectations about what they're seeing and be confused when they don't see what they expect.

Copy link
Member Author

If I understand the change correctly: do we currently tell the user that the API is down? They may have expectations about what they're seeing and be confused when they don't see what they expect.

@telestrial SiacoinFields (the ones that show both siacoin input and the fiat input below) gracefully degrade, meaning they do not show the fiat input if the exchange rate is not available.
The renterd pinned configuration fields get completely disabled and show the user a warning message stating that the API is required for the feature.

It would probably be a good improvement to show a similar warning on SiacoinField. I'll create an issue: #777

Copy link
Member Author

alexfreska commented Oct 11, 2024

Merge activity

  • Oct 11, 1:53 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 11, 1:53 PM EDT: A user merged this pull request with Graphite.

@alexfreska alexfreska merged commit 1d1452d into main Oct 11, 2024
32 checks passed
@alexfreska alexfreska deleted the fix_renterd_config_fields_blank_sia_central branch October 11, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants