-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(renterd): config fields blank sia central #767
Conversation
alexfreska
commented
Oct 7, 2024
•
edited
Loading
edited
- Fixed an issue where configured settings would show as blank when the Sia Central API (used for network averages) was down. Autopilot settings are not visible in UI when Siacentral API is down renterd#1601
- Fixed an issue where SiacoinField was depending on the siaCentral setting rather than the active exchange rate API.
- Refactoring
- Refactored the internal autopilotInfo usage to be more clear.
- Refactored useResources and resources into one file.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
🦋 Changeset detectedLatest commit: d6b71d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
528e5f4
to
74c1d78
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alexfreska and the rest of your teammates on Graphite |
74c1d78
to
175f4d1
Compare
175f4d1
to
9f1a563
Compare
9f1a563
to
ded1200
Compare
ded1200
to
271c8f8
Compare
271c8f8
to
8343aff
Compare
8343aff
to
d6b71d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the change correctly: do we currently tell the user that the API is down? They may have expectations about what they're seeing and be confused when they don't see what they expect.
@telestrial SiacoinFields (the ones that show both siacoin input and the fiat input below) gracefully degrade, meaning they do not show the fiat input if the exchange rate is not available. It would probably be a good improvement to show a similar warning on SiacoinField. I'll create an issue: #777 |