Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: renterd hostd wallet send #705

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Aug 28, 2024

Blocked by SiaFoundation/hostd#454
Relates to SiaFoundation/renterd#1436

renterd

  • The send siacoin feature now calculates the fee using the daemon's recommended fee and a standard transaction size.
  • Add e2e tests for sending siacoin.

renterd sdks

  • Fixed the recommended fee API route.
  • Added the wallet send API.

hostd

  • The send siacoin feature now calculates the fee using the daemon's recommended fee and a standard transaction size.
  • Add e2e tests for sending siacoin.
  • Refactor test setup with beforeTest helper.

hostd sdks

  • The wallet send API now supports the subtractMinerFee option.

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hostd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 7:14pm
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 7:14pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 7:14pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 7:14pm
website ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 7:14pm

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 1493ed6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
hostd Minor
renterd Minor
@siafoundation/hostd-types Minor
@siafoundation/hostd-js Minor
@siafoundation/hostd-react Minor
@siafoundation/renterd-js Minor
@siafoundation/renterd-react Minor
@siafoundation/renterd-types Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

alexfreska commented Aug 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

@n8maninger
Copy link
Member

n8maninger commented Aug 28, 2024

@alexfreska stick to confirmed outputs for sending siacoins even if it means failure

@alexfreska alexfreska merged commit 81d374f into main Aug 30, 2024
18 checks passed
@alexfreska alexfreska deleted the feat_renterd_wallet_send branch August 30, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants