Skip to content

Conversation

@gugu
Copy link
Member

@gugu gugu commented Nov 11, 2025

Potential fix for https://github.com/Short-io/qreator/security/code-scanning/1

To fix the problem, we should add a permissions block to the build job in .github/workflows/test.yml, specifying the least privilege required. For a typical build/test job, this is usually contents: read, which allows the job to read repository contents but not write to them. This change should be made directly under the build: job definition, before the runs-on: key (or immediately after, as per YAML conventions). No additional imports or definitions are needed; this is a configuration change in the workflow YAML file.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@gugu gugu marked this pull request as ready for review November 11, 2025 08:47
@gugu gugu requested review from Copilot and igorrybak November 11, 2025 08:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a security code scanning alert by adding explicit permissions to the GitHub Actions workflow. The change implements the principle of least privilege by restricting the workflow job to only read repository contents.

  • Added permissions block to the build job with contents: read scope

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gugu gugu merged commit 5972c48 into master Nov 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants