Skip to content

Conversation

@BrittaEvansFenton
Copy link
Contributor

@BrittaEvansFenton BrittaEvansFenton commented Dec 4, 2025

Background

When working on this PR I accidentally missed pushing up the components file change, so the change was on my locally version, which is why it worked in the preview link.
(Provide a link to any relevant issues AND provide a TLDR of the issue in this pull request)

🎩

To run it locally:

  1. pull this branch down from ui-extensions
  2. and pull this branch from shopify-dev : https://github.com/Shopify/shopify-dev/pull/65581
  3. In shopify-dev, run dev server
  4. Press CTRL-T to open the dev server in a browser. Please note that some rendering errors may occur, if this is the case, either click on ignore if the option is there and try refreshing the browser a couple of times if not an option.

Checklist

  • I have 🎩'd these changes
    - [ ] I have updated relevant documentation Will do as part of 1 big push closer to the end of the project.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

Copy link
Contributor

Just making sure I understand

To run it locally:
1. pull this branch down from ui-extensions
2. and pull this branch from shopify-dev : https://github.com/Shopify/shopify-dev/pull/65581
3. In shopify-dev, run dev server
4. Press CTRL-T to open the dev server in a browser. Please note that some rendering errors may occur, if this is the case, either click on ignore if the option is there and try refreshing the browser a couple of times if not an option.

After I do this, what should I look for? Or what should I test?

Copy link
Contributor Author

BrittaEvansFenton commented Dec 9, 2025

oops, sorry that context was in the other PR, you need to confirm that on image there is the alt prop available on the 2025-10 version

Copy link
Contributor Author

Before:

Screenshot 2025-12-09 at 3.00.36 PM.png

After:

Screenshot 2025-12-09 at 3.00.07 PM.png

Copy link
Contributor

LGTM! I tophatted locally.

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants