Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulkCartUpdate to useCartApi / removes deprecated customer props #2531

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

vctrchu
Copy link
Contributor

@vctrchu vctrchu commented Dec 13, 2024

Part of https://github.com/Shopify/pos-next-react-native/issues/47966

Background

This PR adds the following to the useCartApi for POS UI Extensions:

  • A new action called bulkCartUpdate which returns a Cart
  • New types called CartUpdateInput

Video of updated cart being returned on promise completion:

Screen.Recording.2024-12-17.at.10.10.34.AM.mov

@vctrchu vctrchu self-assigned this Dec 13, 2024
@vctrchu

This comment was marked as outdated.

@shopify-github-actions-access

This comment was marked as outdated.

@vctrchu

This comment was marked as resolved.

@vctrchu vctrchu force-pushed the vic/bulk-cart-update branch from e2d3774 to c7930ae Compare December 16, 2024 19:23
@vctrchu vctrchu marked this pull request as ready for review December 16, 2024 19:23

This comment has been minimized.

@vctrchu vctrchu force-pushed the vic/bulk-cart-update branch from 4845df7 to e4f92a2 Compare December 16, 2024 23:27
@vctrchu
Copy link
Contributor Author

vctrchu commented Dec 16, 2024

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @vctrchu! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/data-extensions": "0.0.0-snapshot-20241216234442",
"@shopify/ui-extensions": "0.0.0-snapshot-20241216234442",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20241216234442"

@vctrchu vctrchu force-pushed the vic/bulk-cart-update branch from ed3b5a2 to 5322d77 Compare December 17, 2024 20:01
Copy link
Contributor

@NathanJolly NathanJolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say this is a minor change, not a patch change, but I don't think it actually matters as it doesn't map to a semver.

@vctrchu vctrchu changed the title Add bulkCartUpdate to useCartApi Add bulkCartUpdate to useCartApi / removes deprecated customer props Dec 17, 2024
Add changeset

Update @shopify/ui-extensions version to minor
@vctrchu vctrchu force-pushed the vic/bulk-cart-update branch from a4d3fd8 to 74b06c4 Compare December 17, 2024 21:55
@vctrchu vctrchu merged commit 29d4cb5 into unstable Dec 17, 2024
6 checks passed
@vctrchu vctrchu deleted the vic/bulk-cart-update branch December 17, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants