-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bulkCartUpdate to useCartApi / removes deprecated customer props #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
vctrchu
force-pushed
the
vic/bulk-cart-update
branch
from
December 16, 2024 19:23
e2d3774
to
c7930ae
Compare
This comment has been minimized.
This comment has been minimized.
vctrchu
commented
Dec 16, 2024
vctrchu
commented
Dec 16, 2024
packages/ui-extensions/src/surfaces/point-of-sale/types/cart.ts
Outdated
Show resolved
Hide resolved
vctrchu
commented
Dec 16, 2024
packages/ui-extensions/docs/surfaces/point-of-sale/staticPages/pages/versions.doc.ts
Show resolved
Hide resolved
vctrchu
commented
Dec 16, 2024
packages/ui-extensions/src/surfaces/point-of-sale/render/api/cart-api/cart-api.ts
Outdated
Show resolved
Hide resolved
vctrchu
force-pushed
the
vic/bulk-cart-update
branch
from
December 16, 2024 23:27
4845df7
to
e4f92a2
Compare
/snapit |
🫰✨ Thanks @vctrchu! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/data-extensions": "0.0.0-snapshot-20241216234442",
"@shopify/ui-extensions": "0.0.0-snapshot-20241216234442",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20241216234442" |
vctrchu
force-pushed
the
vic/bulk-cart-update
branch
from
December 17, 2024 20:01
ed3b5a2
to
5322d77
Compare
js-goupil
approved these changes
Dec 17, 2024
NathanJolly
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say this is a minor
change, not a patch
change, but I don't think it actually matters as it doesn't map to a semver.
vctrchu
changed the title
Add bulkCartUpdate to useCartApi
Add bulkCartUpdate to useCartApi / removes deprecated customer props
Dec 17, 2024
Add changeset Update @shopify/ui-extensions version to minor
vctrchu
force-pushed
the
vic/bulk-cart-update
branch
from
December 17, 2024 21:55
a4d3fd8
to
74b06c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/Shopify/pos-next-react-native/issues/47966
Background
This PR adds the following to the useCartApi for POS UI Extensions:
bulkCartUpdate
which returns aCart
CartUpdateInput
Video of updated cart being returned on promise completion:
Screen.Recording.2024-12-17.at.10.10.34.AM.mov