Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop log_v23_deprecations console warning #1924

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Drop log_v23_deprecations console warning #1924

merged 1 commit into from
Dec 18, 2024

Conversation

tamcgoey
Copy link
Contributor

What this PR does

We've seen this console warning for 8 months with each app boot in dev, thinking we could remove the warning.

Especially since if there's breaking changes they are could be raised in the changelog + via exceptions.

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@tamcgoey tamcgoey requested a review from a team as a code owner November 26, 2024 17:05
@tamcgoey tamcgoey self-assigned this Nov 26, 2024
@Arkham
Copy link
Contributor

Arkham commented Dec 17, 2024

Shouldn't we drop the warning when releasing v23? or am I missing something?

@tamcgoey
Copy link
Contributor Author

We could, just that this has been logging for 8 months now and v23 hasn't been released any time since then.

It's just annoying we see this error every time we boot up the app.

@Arkham
Copy link
Contributor

Arkham commented Dec 17, 2024

I see! Let me touch base with the team and see why we haven't released v23 yet :)

Copy link
Contributor

@Arkham Arkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I've spoken with the team and they're happy to remove the logs!

@tamcgoey tamcgoey merged commit 2dd9feb into main Dec 18, 2024
8 checks passed
@tamcgoey tamcgoey deleted the drop_warning branch December 18, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants