Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to upload SkImage to GPU to cache as a texture.
Skia doesn't cache images as textures automatically, so on each
drawImage
call it will upload it to GPU to draw. It's fine when you render a few images, but if you need to render 20-30 images it becomes a problem, especially on Android. On iOS it's mostly fine. I assume copying images from cpu to gpu is much faster on iOS.I added
MakeTextureFromImage
for ImageFactory (Skia.Image
).Also I added
isTextureBacked()
andtextureSize()
to SkImage which are helpful when you work with textures.It was tested on both iOS and Android.
As part of this PR, I exposed
getDirectContext
on Platform Context for both iOS and Android. It is used for the TextureFromImage call, but probably will be used for other APIs in the future.