This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Allow merging of mocked queries in GraphQL update #2676
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows applying partial changes to the mocked graphQL queries provided by the
GraphQLController
. This works similarly to the existingupdate
option, but merges the existing mocked queries with the new set. This is useful in two cases that I think are relevant:Open questions
Should this be the default behaviour of the
update
function? I don't think many will be relying on the removal of mocks in their tests, which I think would be the only way this would break if this was the default behaviour ofupdate
.Another approach might be to expose the mocks to the consumer so that we can reuse them. The result of
createGraphQL
is currently sealed, but it would be useful if we can take an existing helper that gives us acreateGraphQL
and be able to extend it to supply more mocks for other queries, without having to know what was passed in initially.