Removing onCompleted and onError from the useQuery types

[alexandcote]

Description

Our custom implementation of useQuery and <Query /> doesn't support onCompleted and onError.

This PR update the types to reflect the difference between our API and Apollo API.

[BPScott]

Change looks reasonable though I'm concerned that folks might have been using these props without realising they do nothing, and thus removing them from the type will introduce a bunch of type errors in web. Could you please cut a snapshot and test if using it in web has an effect on running type-check?

[BPScott]

/snapit

[github-actions]

🫰✨ Thanks @BPScott! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]

yarn add @shopify/[email protected]

[alexandcote]

I see some instances

[BPScott]

Looks like the impact in web is pretty light and if we release this fixing web's CI would be pretty quick. I'm ok with claiming this is a patch release and we have to fix those places in web.

Code changes look good, I've added a suggestion for how to format the changeset so something that would feel a bit nicer to read as a changelog entry.

Alex, can you own getting this updated within web, so we we don't have to do the tidying as part of some future update?

[BPScott]

LGTM. Can you own getting this updated in web (I've moved onto checkout things).