Remove card shadows from smaller breakpoints #12877
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Germanika
force-pushed
the
remove-use-breakpoints-use-in-cards
branch
from
feba02c
to
6fee7aa
Compare
Germanika
force-pushed
the
remove-use-breakpoints-use-in-cards
branch
from
6fee7aa
to
b0702da
Compare
|
/snapit |
|
🫰✨ Thanks @Germanika! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20241112004800" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #11968
Re-implementation of #11926
WHAT is this pull request doing?
Removes Card and LegacyCard default bevel styles below the sm breakpoint. Essentially if card corners aren’t rounded then shadow styles are removed as well.
Currently the Card component toggles border-radius at certain breakpoints with the roundedAbove prop (and defaults to the sm breakpoint). This PR also adds box-shadow to these toggled styles.
This is also removing the reliance on
useBreakpoints()in theCardcomponent. Currently theborderRadiusdoes not apply on an initial SSR render becauseuseBreakpointsrelies on the client-side render to determine the browser size. So we default to the mobile style with square corners (and no shadow/bevel) on initial SSR before getting the rounded corners on client-side render.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes