Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move containerBounds to ChartContext #1763

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

envex
Copy link
Collaborator

@envex envex commented Nov 20, 2024

What does this implement/fix?

As an improvement to #1757 we're moving containerBounds to the ChartContext so we no longer have to prop drill it.

We're also removing containerDimensions which was a subset of containerBounds. We will use containerBounds from now on.

Storybook link

Before merging

  • Check your changes on a variety of browsers and devices.

  • Update the Changelog's Unreleased section with your changes.

  • Update relevant documentation, tests, and Storybook.

  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

Copy link

github-actions bot commented Nov 20, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.65 KB (+0.04% 🔺) 1.3 s (+0.04% 🔺) 1.2 s (+24.04% 🔺) 2.4 s
polaris-viz-cjs 222.7 KB (-0.24% 🔽) 4.5 s (-0.24% 🔽) 2.1 s (+3% 🔺) 6.6 s
polaris-viz-esm 180.54 KB (-0.26% 🔽) 3.7 s (-0.26% 🔽) 1.7 s (+12.4% 🔺) 5.3 s
polaris-viz-css 5.55 KB (-0.15% 🔽) 111 ms (-0.15% 🔽) 344 ms (+9.69% 🔺) 455 ms
polaris-viz-esnext 187.26 KB (-0.28% 🔽) 3.8 s (-0.28% 🔽) 1.3 s (-14.46% 🔽) 5.1 s

@envex envex force-pushed the envex/container-bounds-context branch from a7eb0c5 to 551084c Compare November 20, 2024 19:35
@envex envex marked this pull request as ready for review November 20, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant