Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debarrel packages/polaris-viz #1760

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Debarrel packages/polaris-viz #1760

wants to merge 1 commit into from

Conversation

envex
Copy link
Collaborator

@envex envex commented Nov 19, 2024 •
edited
Loading

What does this implement/fix?

Remove all the index.ts files that only contained exports.

This should have 0 effect on the library as long as all the test pass and the library builds correctly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.63 KB (0%) 1.3 s (0%) 977 ms (+33.47% 🔺) 2.3 s
polaris-viz-cjs 223.05 KB (+0.1% 🔺) 4.5 s (+0.1% 🔺) 1.9 s (-11.34% 🔽) 6.3 s
polaris-viz-esm 180.08 KB (-0.32% 🔽) 3.7 s (-0.32% 🔽) 1.3 s (-0.62% 🔽) 4.9 s
polaris-viz-css 5.57 KB (+0.18% 🔺) 112 ms (+0.18% 🔺) 279 ms (-16.39% 🔽) 390 ms
polaris-viz-esnext 187.09 KB (-0.17% 🔽) 3.8 s (-0.17% 🔽) 1.5 s (-18.93% 🔽) 5.2 s

@envex envex marked this pull request as ready for review November 19, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carysmills carysmills Awaiting requested review from carysmills

@philschoefer philschoefer Awaiting requested review from philschoefer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@envex