-
Notifications
You must be signed in to change notification settings - Fork 354
Delete @shopify/remix-oxygen #3129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kdaviduik
wants to merge
7
commits into
hydrogen-react-router-7.8.2-clean
Choose a base branch
from
kd-remove-remix-oxygen
base: hydrogen-react-router-7.8.2-clean
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Delete @shopify/remix-oxygen #3129
kdaviduik
wants to merge
7
commits into
hydrogen-react-router-7.8.2-clean
from
kd-remove-remix-oxygen
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
fdcfcfe
to
ae46e1d
Compare
Creates new oxygen export with: - createRequestHandler: Oxygen-specific wrapper around React Router's handler - Request validation (GET/HEAD with body check) - URL normalization (double slash handling) - Powered-by header injection - getStorefrontHeaders: Extract Oxygen headers from requests This replaces the functionality from @shopify/remix-oxygen
ae46e1d
to
d10d372
Compare
Adds Error.prototype.toString override to Vite's crossBoundarySetup so it's automatically injected into Oxygen worker environments. This replaces the runtime override that was in remix-oxygen.
Updates /// <reference types> directives in env.d.ts files to use @shopify/oxygen-workers-types instead of @shopify/remix-oxygen
All types and functions that were re-exported from remix-oxygen are now imported directly from react-router since they are available in React Router 7.6.0
Removes the entire @shopify/remix-oxygen package as all functionality has been: - Moved to @Shopify/hydrogen/oxygen (createRequestHandler, getStorefrontHeaders) - Available from react-router 7.6.0 (all type re-exports) - Handled by Vite (stack traces, H2O_LOG_EVENT) - Deprecated (event-logger.ts - only for classic Remix compiler)
- Remove remix-oxygen from main README.md package list - Update CONTRIBUTING.md to remove remix-oxygen package description - Update all cookbook recipe READMEs to use react-router imports - Update all cookbook LLM prompts to use react-router imports - Update example READMEs to use react-router module declarations - Update RFC documentation to use react-router and @Shopify/hydrogen/oxygen imports
d10d372
to
e818e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes https://github.com/Shopify/hydrogen-internal/issues/227. TLDR: Hydrogen has moved from Remix onto React Router 7. We want to remove/replace all Remix-related dependencies
WHAT is this pull request doing?
I recommend reviewing commit by commit to be able to review the changes more easily
HOW to test your changes?
Post-merge steps
Checklist