Skip to content

Conversation

juanpprieto
Copy link
Contributor

@juanpprieto juanpprieto commented Apr 10, 2025

  • Added react-router
  • Removed @remix-run/server-runtime

TODO:

  • content-security-policy-builder ?
  • worktop/cookie ?

react-router WIP Log

Failed to resolve dependency: content-security-policy-builder, present in client 'optimizeDeps.include'
Failed to resolve dependency: worktop/cookie, present in client 'optimizeDeps.include'
Failed to resolve dependency: @remix-run/server-runtime, present in ssr 'optimizeDeps.include'
➜ Local: http://localhost:5173/
➜ Network: use --host to expose
➜ press h + enter to show help

Warning: MiniOxygen couldn't load your app's entry point.
Try adding "react-router" to the "ssr.optimizeDeps.include" array in your Vite config.

Warning: MiniOxygen couldn't load your app's entry point.
Try adding "react-router" to the "ssr.optimizeDeps.include" array in your Vite config.

Warning: MiniOxygen couldn't load your app's entry point.
Try adding "react-router" to the "ssr.optimizeDeps.include" array in your Vite config.

Warning: MiniOxygen couldn't load your app's entry point.
Try adding "react-router" to the "ssr.optimizeDeps.include" array in your Vite config.

Warning: MiniOxygen couldn't load your app's entry point.
Try adding "react-router" to the "ssr.optimizeDeps.include" array in your Vite config

Copy link
Contributor

shopify bot commented Apr 10, 2025

Oxygen deployed a preview of your juanpprieto/add-react-router-to-optimizeDeps branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment April 10, 202510:32 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment April 10, 202510:32 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment April 10, 202510:32 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment April 10, 202510:32 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment April 10, 202510:32 PM

Learn more about Hydrogen's GitHub integration.

@juanpprieto juanpprieto requested a review from Copilot April 10, 2025 22:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@juanpprieto juanpprieto changed the title Add react-router to optimizeDeps Update hydrogen vite plugin optimizeDeps include list for react-router Apr 10, 2025
@juanpprieto juanpprieto marked this pull request as draft April 10, 2025 22:32
Copy link
Contributor

This pull request has been marked as stale due to inactivity for 60 days. If no further activity occurs, it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant