Update multiple bulk quick add modals for parity throughout multiple sections#3619
Closed
cfxd wants to merge 1 commit intoShopify:mainfrom
Closed
Update multiple bulk quick add modals for parity throughout multiple sections#3619cfxd wants to merge 1 commit intoShopify:mainfrom
cfxd wants to merge 1 commit intoShopify:mainfrom
Conversation
8b18d24 to
c623d27
Compare
Refresh quick order list elements after rendering Simplify the refresh Better variable naming Better refresh after render Clean up variant selector
c623d27 to
fc82fde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary:
Fixes multiple bulk quick add modals on the same page not updating properly
Why are these changes introduced?
Problem demo @
multi-quick-add-modal.mp4
When multiple sections each contain the same product, only the first quick add modal updates because the current script relies heavily on element IDs
What approach did you take?
Introduced a way to update multiple elements
Testing steps/scenarios
Demo links
Checklist