Fix to invalid keyframes in component-pickup-availability.css#3618
Closed
Matt-Kaminski wants to merge 1 commit intoShopify:mainfrom
Closed
Fix to invalid keyframes in component-pickup-availability.css#3618Matt-Kaminski wants to merge 1 commit intoShopify:mainfrom
Matt-Kaminski wants to merge 1 commit intoShopify:mainfrom
Conversation
Correct invalid CSS structure in component-pickup-availability.css The original animateDrawerOpen keyframes contained media queries directly inside the @Keyframes rule, which is not valid CSS syntax. Keyframe animations cannot include media queries in this way. Changes made: 1. Removed invalid media query syntax from within the @Keyframes rule 2. Simplified to a single set of keyframes that applies to all screen sizes The animation now correctly defines the keyframes without attempting to use media queries within the @Keyframes rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original animateDrawerOpen keyframes contained media queries directly inside the keyframes rule, which is not valid CSS syntax. Keyframe animations cannot include media queries in this way.
The animation now correctly defines the keyframes without attempting to use media queries within the keyframes rule.
PR Summary:
Fix pickup availability drawer open animation
What approach did you take?
Visual impact on existing themes
Fix pickup availability drawer open animation
Checklist