fix svg asset inclusion error inside multicolumn section#3610
Closed
nikitasol wants to merge 3 commits intoShopify:mainfrom
Closed
fix svg asset inclusion error inside multicolumn section#3610nikitasol wants to merge 3 commits intoShopify:mainfrom
nikitasol wants to merge 3 commits intoShopify:mainfrom
Conversation
nikitasol
changed the title
Author
|
Also referenced in #3601, but I think class hierarchy is incorrect there. svg-wrapper class should just contain the svg itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary:
Fix to erronious inclusion of new asset svg (icon-arrow.svg) inside multicolumn section.
Why are these changes introduced?
It was breaking arrow display when adding links
What approach did you take?
Code cleaning
Visual impact on existing themes
Fix the arrow icon and show it again.
Checklist