feat: type hinting for runner functions #1071
Open
+29
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin: [BFCL] Fix prompt concatenation bug in Qwen template (ShishirPatil#1068) [BFCL] Multi-turn TravelAPI book_flight() Fix (ShishirPatil#966) _get_item() can not handle the "." directory in path string (ShishirPatil#1060) Add support for llama-3.1-nemotron-ultra-253b-v1 to BFCL (ShishirPatil#1032) [BFCL] Omit Reasoning Content from Chat History for Function-Calling Models (ShishirPatil#1064) [BFCL] Add support for Ling-Lite-V1.5 (ShishirPatil#1056) [BFCL] Added support for DeepSeek-R1-0528 and DeepSeek-V3-0324 (ShishirPatil#1063) [BFCL] Add type hinting (ShishirPatil#1058)
HuanzhiMao
reviewed
Jun 21, 2025
| @@ -33,8 +34,14 @@ def get_handler(model_name): | |||
|
|
|||
|
|
|||
| def multi_turn_runner( | |||
| handler, model_result, prompt, possible_answer, model_name, test_category, score_dir | |||
| ): | |||
| handler: str, | |||
There was a problem hiding this comment.
handler should be of type BaseHandler (from berkeley-function-call-leaderboard/bfcl_eval/model_handler/base_handler.py)
HuanzhiMao
reviewed
Jun 21, 2025
| handler: str, | ||
| model_result: list[dict], | ||
| prompt: list[dict], | ||
| possible_answer: list[dict], |
There was a problem hiding this comment.
possible_answer should be a list of list of strings for multi turn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding some type hinting for the runner functions