feat: Implement MPU config for ADC driver #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable cache with proper MPU config Refactor copy-paste logic into indexable maps Generalize some DMA functionality for ADC and DAC Remove every cache invalidation Rewrite DMA errors Refactor all function and var names
svire-at
approved these changes
Jan 19, 2026
| #define ACTUAL_SAMPLING_RATE 250000 // You need to measure this value using a wave generator with a fixed e.g. 1kHz Sine | ||
| #define STORE_BUF_SIZE 32 * 32 // 2400 for 1 measurement per second. | ||
| // only multiples of 32!!!!!! (64 chunk size of bytes, so 32 for 16bit) | ||
| #define STORE_BUF_SIZE 32 * 32 // 2400 for 1 measurement per second |
Collaborator
There was a problem hiding this comment.
wrong number in the comment
| #define ACTUAL_SAMPLING_RATE 250000 // You need to measure this value using a wave generator with a fixed e.g. 1kHz Sine | ||
| #define STORE_BUF_SIZE 32 * 32 // 2400 for 1 measurement per second. | ||
| // only multiples of 32!!!!!! (64 chunk size of bytes, so 32 for 16bit) | ||
| #define STORE_BUF_SIZE 32 * 32 // 2400 for 1 measurement per second |
Collaborator
There was a problem hiding this comment.
wrong number in the comment
LorenzoBuldorini
approved these changes
Jan 20, 2026
Collaborator
LorenzoBuldorini
left a comment
LorenzoBuldorini
left a comment
There was a problem hiding this comment.
Everything`s look fine, just number calculation for buffer size as Azra pointed out in "projects/UltraSound/extra/ultrasonic_distance_acq_detailed_dataset/ultrasonic_distance_acq_detailed_dataset.ino" and "projects/UltraSound/ultrasonic_distance_acq/ultrasonic_distance_acq.ino"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the Pull Request fulfils these requirements
type: Descriptive NameLink related open issue
[TASK] MPU configuration for ADC driver #74
Provide a short description
Implement MPU config for ADC driver
Provide a more detailed list of changes
Does this PR introduce a breaking change?
N/A
Other information
SensEdu_ADC_Buffer and SensEdu_DAC_Buffer both are using MPU config now, so it doesn't matter which one to use.
There is a new macro SensEdu_DMA_Buffer which is preferable to use to reflect the identical buffer logic.