Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base: Update the Syrian flag #25644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

starrymohannad
Copy link

updated the Syrian flag to the de-facto used by the current goverment

@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jan 13, 2025
@starrymohannad starrymohannad force-pushed the master branch 2 times, most recently from a3e90b5 to d01448f Compare January 13, 2025 12:53
@timschumi
Copy link
Member

See #25588 for existing discussion on the topic. (@DZve: Any particular reason why the PR was closed? Feel free to restore in case it was accidental.)

@timschumi timschumi added the ⛔️ pr-is-blocked PR is blocked by something outside of the author's control, protected from stalebot label Jan 13, 2025
@starrymohannad
Copy link
Author

ok :P

@DZve
Copy link
Contributor

DZve commented Jan 13, 2025

@timschumi Sorry about that, that was my first ever pull request on github and I deleted the original repository. I'll see if I can find a way to restore it later today.

@DZve
Copy link
Contributor

DZve commented Jan 14, 2025

Unfortunately I don't think there's a way for me to restore #25588 since I deleted the original repository for it. This PR (#25644) should be the new PR discussion.

@timschumi
Copy link
Member

Fair enough, then I suppose we will keep moving forward with this PR.

@starrymohannad Please read through the existing discussion about how to optimize the file size that is located in the other PR and apply the same changes here.

@timschumi timschumi changed the title updated the syrian flag Base: Update the Syrian flag Jan 21, 2025
@timschumi
Copy link
Member

Also, please use the common commit title format (i.e. "Update" instead of "Updated"), and I think "Syrian" is capitalized in this context.

@starrymohannad
Copy link
Author

starrymohannad commented Jan 31, 2025

I have ran it through optipng -strip all Base/res/emoji/U+1F1F8_U+1F1FE.png and it said that the image is already optimized

I have also Changed the name of the commit

@starrymohannad
Copy link
Author

Oh wait nevermind

I have put the wrong path lol :P

@starrymohannad
Copy link
Author

starrymohannad commented Jan 31, 2025

oh shot... I replaced the Iraqi flag ( ._.)

@starrymohannad
Copy link
Author

fixed it :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔️ pr-is-blocked PR is blocked by something outside of the author's control, protected from stalebot 👀 pr-needs-review PR needs review from a maintainer or community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants