Fix Ruff CI errors

[stared]

A potential solution for #937

Do you give it a go @Serene-Arc ?
I am open to other solutions for Ruff, if needed.

[Serene-Arc]

Hi, there are a bunch of other changes here that don't relate to the ruff error. Can you give your reasoning for those or maybe put them in their own explanatory commits?

[Serene-Arc]

I'm honestly at a bit of a loss to explain why the master protection check is failing. That's weird.

[stared]

Hi @Serene-Arc !

These changes are to fix linting errors discovered by Ruff (previously, it was not seeing that, as it was not working):

ruff check .

tests/integration_tests/test_download_integration.py:44:9: PT014 Duplicate of test case at index 1 in `@pytest_mark.parametrize`
   |
42 |         ["-s", "EmpireDidNothingWrong", "-L", 3],
43 |         ["-s", "r/EmpireDidNothingWrong", "-L", 3],
44 |         ["-s", "r/EmpireDidNothingWrong", "-L", 3],
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PT014
45 |         ["-s", "EmpireDidNothingWrong", "-L", 3],
46 |         ["-s", "https://www.reddit.com/r/TrollXChromosomes/", "-L", 3],
   |
   = help: Remove duplicate test case

tests/integration_tests/test_download_integration.py:45:9: PT014 Duplicate of test case at index 0 in `@pytest_mark.parametrize`
   |
43 |         ["-s", "r/EmpireDidNothingWrong", "-L", 3],
44 |         ["-s", "r/EmpireDidNothingWrong", "-L", 3],
45 |         ["-s", "EmpireDidNothingWrong", "-L", 3],
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PT014
46 |         ["-s", "https://www.reddit.com/r/TrollXChromosomes/", "-L", 3],
47 |         ["-s", "r/TrollXChromosomes/", "-L", 3],
   |
   = help: Remove duplicate test case

tests/test_file_name_formatter.py:534:85: PTH201 [*] Do not pass the current directory explicitly to `Path`
    |
532 |     test_filename: str, test_ending: str, expected_end: str, test_formatter: FileNameFormatter
533 | ):
534 |     result = test_formatter.limit_file_name_length(test_filename, test_ending, Path("."))
    |                                                                                     ^^^ PTH201
535 |     assert result.name.endswith(expected_end)
536 |     assert len(str(result)) <= FileNameFormatter.find_max_path_length()
    |
    = help: Remove the current directory argument

Found 3 errors.
[*] 1 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

I committed these changes with a separate commit (ff27049), for clarity.

When it comes to the "Protect master branch / merge_check (pull_request)" - it is protected (and from one I see, unused). By mistake, I created a PR to master, only later changed it to development (but it didn't rerun tests).

Sadly, "Python Test / test (ubuntu-latest, 3.9, .sh) (pull_request)" is failing, but it was in the same way with all other PRs and commits. I am unsure if it was due to code changes or Reddit changing its way - it deserves another Issue/PR. Tests with external API calls are (while often necessary) a tricky thing.

[Serene-Arc]

The tests fail due to the token that Ali has set up as the repository secret still being the BDFR's token, instead of a private one. That means that we're sharing the rate limit with every other BDFR user that hasn't changed the token, and the tests fail. I don't have the ability to change that token, so the tests are failing.

[stared]

Too bad! I assume Ali does not have space to change that.

In this case, it is burning 3x40min of GitHub Actions, and hardly informative. For one project, I did two test sets - one internal and the other - everything involving an external API.

Anyway, regarding Ruff - does it look good to you, and is it up for merging?

[stared]

@Serene-Arc And how about this PR? Would you like to merge it?

[Serene-Arc]

lgtm