Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] deleted the deprecated FormEncodedData #14688

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

joerg1985
Copy link
Member

@joerg1985 joerg1985 commented Oct 30, 2024

User description

Description

This PR will delete the deprecated FormEncodedData and the related unittests.
I assume this has not been used for years, so this can be removed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement, Tests


Description

  • Removed the deprecated FormEncodedData class from the codebase, which was marked for removal.
  • Deleted all associated unit tests for the FormEncodedData class, which tested form-encoded data handling.

Changes walkthrough 📝

Relevant files
Enhancement
FormEncodedData.java
Remove deprecated `FormEncodedData` class                               

java/src/org/openqa/selenium/remote/http/FormEncodedData.java

  • Removed the entire FormEncodedData class.
  • The class was marked as deprecated for removal.
  • +0/-95   
    Tests
    FormEncodedDataTest.java
    Remove tests for deprecated `FormEncodedData` class           

    java/test/org/openqa/selenium/remote/http/FormEncodedDataTest.java

  • Deleted all unit tests related to FormEncodedData.
  • Tests covered various scenarios for form-encoded data handling.
  • +0/-150 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Deprecation Removal
    Verify that the removal of FormEncodedData does not break any existing functionality or dependencies in the project.

    Test Removal
    Ensure that the removal of FormEncodedDataTest does not leave any gaps in test coverage for related functionality.

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @joerg1985
    Copy link
    Member Author

    /help "In what year has the FormEncodedData been used the last time, beside unit tests?"

    Copy link
    Contributor

    Question:

    In what year has the FormEncodedData been used the last time, beside unit tests?

    Answer:

    Based on the provided documentation, there is no specific information about when FormEncodedData was last used outside of unit tests. The documentation does not contain any references to FormEncodedData or its usage history. To accurately answer this question, we would need access to the project's codebase and commit history, which is not available in the given documentation.

    Relevant Sources:

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant