Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Ord, Hash and Default for Expansions iter #49

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Implement Ord, Hash and Default for Expansions iter #49

merged 2 commits into from
Oct 26, 2023

Conversation

swooster
Copy link
Contributor

Intent

Implement traits/helpers I discovered I wanted on Expansions.

Changes

  • Implement PartialOrd, Ord, Hash and Default for expansions.
  • Add Expansions::empty helper that produces no expansions.

franssl
franssl approved these changes Oct 26, 2023
View reviewed changes
Copy link

@franssl franssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍

You could possibly leave a comment to explain the need for this.next() in the empty() function.

@swooster swooster merged commit 0d015f2 into main Oct 26, 2023
8 checks passed
@swooster swooster deleted the swooster/expansions-more-traits branch October 26, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franssl franssl franssl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swooster @franssl