refactor: upgrade react-day-picker to v9
#398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SeanCassiere
commented
Aug 1, 2024
|
|
||
| const oldestYear = fromYear ?? DEFAULT_FROM_YEAR; | ||
| const newestYear = toYear ?? currentYear + 15; | ||
| const calendarHiddenOptions: Matcher[] = [ |
There was a problem hiding this comment.
Relying on the react-compiler to perform auto memoizations here for better perf.
| @@ -212,8 +221,9 @@ function CalendarDropdown(props: DropdownProps) { | |||
| ); | |||
| } | |||
|
|
|||
| return null; | |||
| return <div>dropdown</div>; | |||
There was a problem hiding this comment.
Currently, dropdown is only ever used for the selection of months and year. Ofc, we'll have to revisit this later should there be a need to use it for more than the aforementioned options.
| @@ -76,13 +76,13 @@ function InputDatePicker({ | |||
| {children} | |||
| <PopoverContent | |||
| align={align} | |||
| className="max-w-[300px] px-0 pb-1.5 pt-1" | |||
| className="w-full max-w-[400px] px-0 pb-1.5 pt-1" | |||
There was a problem hiding this comment.
The width change doesn't seem to do anything 🤔.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the
react-day-pickerto v9 and resolves the breaking changes introduced with the version bump.