Skip to content

Commit

Permalink
fix: invalid icon element props and failed invariant error from the `…
Browse files Browse the repository at this point in the history
…<Link>` on the check-in page (#395)

* fix: invalid element props on the icons

* fix: the agreement `from` value for the breadcrumb to go back
  • Loading branch information
SeanCassiere authored Jul 30, 2024
1 parent 963bcff commit ff01c56
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 8 deletions.
6 changes: 5 additions & 1 deletion src/components/add-rental/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,11 @@ function AddRentalParentForm({
{isEdit && module === "agreement" && (
<>
<Link
from="/agreements/$agreementId/edit"
from={
isCheckin
? "/agreements/$agreementId/check-in"
: "/agreements/$agreementId/edit"
}
to=".."
className="text-2xl font-semibold leading-6"
>
Expand Down
14 changes: 7 additions & 7 deletions src/components/ui/icons.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,15 @@ export const icons = {
Twitter: (props: SvgProps) => {
return (
<svg
stroke-linejoin="round"
strokeLinejoin="round"
viewBox="0 0 16 16"
aria-label="Twitter"
style={{ color: "currentcolor" }}
{...props}
>
<path
fill-rule="evenodd"
clip-rule="evenodd"
fillRule="evenodd"
clipRule="evenodd"
d="M0.5 0.5H5.75L9.48421 5.71053L14 0.5H16L10.3895 6.97368L16.5 15.5H11.25L7.51579 10.2895L3 15.5H1L6.61053 9.02632L0.5 0.5ZM12.0204 14L3.42043 2H4.97957L13.5796 14H12.0204Z"
fill="currentColor"
></path>
Expand All @@ -147,16 +147,16 @@ export const icons = {
GitHub: (props: SvgProps) => {
return (
<svg
stroke-linejoin="round"
strokeLinejoin="round"
viewBox="0 0 16 16"
aria-label="GitHub"
style={{ color: "currentcolor" }}
{...props}
>
<g clip-path="url(#clip0_872_3147)">
<g clipPath="url(#clip0_872_3147)">
<path
fill-rule="evenodd"
clip-rule="evenodd"
fillRule="evenodd"
clipRule="evenodd"
d="M8 0C3.58 0 0 3.57879 0 7.99729C0 11.5361 2.29 14.5251 5.47 15.5847C5.87 15.6547 6.02 15.4148 6.02 15.2049C6.02 15.0149 6.01 14.3851 6.01 13.7154C4 14.0852 3.48 13.2255 3.32 12.7757C3.23 12.5458 2.84 11.836 2.5 11.6461C2.22 11.4961 1.82 11.1262 2.49 11.1162C3.12 11.1062 3.57 11.696 3.72 11.936C4.44 13.1455 5.59 12.8057 6.05 12.5957C6.12 12.0759 6.33 11.726 6.56 11.5261C4.78 11.3262 2.92 10.6364 2.92 7.57743C2.92 6.70773 3.23 5.98797 3.74 5.42816C3.66 5.22823 3.38 4.40851 3.82 3.30888C3.82 3.30888 4.49 3.09895 6.02 4.1286C6.66 3.94866 7.34 3.85869 8.02 3.85869C8.7 3.85869 9.38 3.94866 10.02 4.1286C11.55 3.08895 12.22 3.30888 12.22 3.30888C12.66 4.40851 12.38 5.22823 12.3 5.42816C12.81 5.98797 13.12 6.69773 13.12 7.57743C13.12 10.6464 11.25 11.3262 9.47 11.5261C9.76 11.776 10.01 12.2558 10.01 13.0056C10.01 14.0752 10 14.9349 10 15.2049C10 15.4148 10.15 15.6647 10.55 15.5847C12.1381 15.0488 13.5182 14.0284 14.4958 12.6673C15.4735 11.3062 15.9996 9.67293 16 7.99729C16 3.57879 12.42 0 8 0Z"
fill="currentColor"
></path>
Expand Down

0 comments on commit ff01c56

Please sign in to comment.