Skip Rust's escaping in the enum_def macro (#793) #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
RichardWGNR
commented
Jul 13, 2024
There was a problem hiding this comment.
I could reduce the number of allocations, but that's not the point here.
sandhose
reviewed
Aug 6, 2024
Comment on lines
+67
to
+69
| if inner.starts_with("r#") { | ||
| inner = (&inner[2..]).to_string(); | ||
| } |
There was a problem hiding this comment.
There is a IdentExt::unraw helper which does exactly this
|
sea-query-attr is now deprecated. can you open a new PR for sea-query-derive? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
New Features
No
Bug Fixes
Yes. Please see the #793 issue
Breaking Changes
No
Changes
No