add support for SQLite strict tables #493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it might make sense to rewrite this PR in terms of |
billy1624
reviewed
Dec 22, 2022
| @@ -101,6 +101,7 @@ pub trait TableBuilder: IndexBuilder + ForeignKeyBuilder + QuotedBuilder + Table | |||
| TableOpt::Engine(s) => format!("ENGINE={}", s), | |||
| TableOpt::Collate(s) => format!("COLLATE={}", s), | |||
| TableOpt::CharacterSet(s) => format!("DEFAULT CHARSET={}", s), | |||
| TableOpt::Strict => "STRICT".to_string(), | |||
There was a problem hiding this comment.
Hey @evgeniy-terekhin, sorry for the delay.
Since STRICT is a SQLite only keyword, we better append it on SQLite's table_builder instead of doing it in the common table_builder.
|
@evgeniy-terekhin hello! Sorry with the delay. I think is better split TableOpt into backend specific options, what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds support for sqlite strict tables
it does so by adding a new variant to
TableOptvariantexample:
create table test(a, b)(regular create statement)create table test(a int, b int) strict(strict create statement)Questions
TableOptthe right place to put this functionality in?TableOpthave to be public given that there are builder methods for each individual option?TableBuilder::table_prepare_create_statementhas only a default impl andTableOptsattempt to be rendered for any backend even though only MySQL (and SQLite starting with this PR) need those? I am pretty sure I understand why it is so (for the sake of code sharing probably) but wouldn't it make sense for each backend to have it's own implementation?