Skip to content

Conversation

@lennartkloock
Copy link
Member

@lennartkloock lennartkloock commented Mar 27, 2025

  • Rewrite scuffle-amf0 with serde support

CLOUD-91

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 27, 2025

Deploying scuffle-docrs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2106829
Status: ✅  Deploy successful!
Preview URL: https://74520a43.scuffle-docrs.pages.dev
Branch Preview URL: https://pr-421.scuffle-docrs.pages.dev

View logs

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 91.35170% with 135 lines in your changes missing coverage. Please review.

Project coverage is 84.16%. Comparing base (956bffc) to head (2106829).
Report is 64 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/amf0/src/de/mod.rs 84.82% 51 Missing ⚠️
crates/amf0/src/ser.rs 93.22% 24 Missing ⚠️
crates/bytes-util/src/zero_copy.rs 69.04% 13 Missing ⚠️
crates/amf0/src/decoder.rs 93.67% 11 Missing ⚠️
crates/amf0/src/value.rs 93.71% 10 Missing ⚠️
crates/amf0/src/de/stream.rs 89.18% 4 Missing ⚠️
crates/amf0/src/encoder.rs 94.52% 4 Missing ⚠️
crates/flv/src/video/body/enhanced/metadata.rs 78.94% 4 Missing ⚠️
crates/amf0/src/error.rs 50.00% 3 Missing ⚠️
crates/bytes-util/src/cow/string/serde.rs 94.23% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   84.02%   84.16%   +0.14%     
==========================================
  Files         215      225      +10     
  Lines       15140    15843     +703     
==========================================
+ Hits        12722    13335     +613     
- Misses       2418     2508      +90     
Files with missing lines Coverage Δ
crates/amf0/src/lib.rs 100.00% <100.00%> (ø)
crates/bytes-util/src/cow/bytes/mod.rs 100.00% <100.00%> (ø)
crates/bytes-util/src/cow/bytes/serde.rs 100.00% <100.00%> (ø)
crates/bytes-util/src/cow/string/mod.rs 100.00% <100.00%> (ø)
crates/flv/src/file.rs 100.00% <ø> (ø)
crates/flv/src/tag.rs 82.75% <ø> (ø)
crates/flv/src/video/body/enhanced/mod.rs 95.45% <100.00%> (-0.06%) ⬇️
crates/flv/src/video/body/mod.rs 100.00% <ø> (ø)
crates/flv/src/video/mod.rs 100.00% <ø> (ø)
...tes/rtmp/src/command_messages/netconnection/mod.rs 94.44% <100.00%> (+3.53%) ⬆️
... and 20 more

... and 37 files with indirect coverage changes

Components Coverage Δ
scuffle-aac 89.65% <ø> (ø)
scuffle-amf0 90.61% <90.61%> (-9.39%) ⬇️
scuffle-av1 98.44% <ø> (-0.23%) ⬇️
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 84.05% <ø> (-1.96%) ⬇️
scuffle-bytes-util 96.78% <94.36%> (-3.22%) ⬇️
scuffle-context 100.00% <ø> (ø)
scuffle-expgolomb 100.00% <ø> (ø)
scuffle-ffmpeg 90.92% <ø> (-0.33%) ⬇️
scuffle-flv 95.90% <88.33%> (-0.69%) ⬇️
scuffle-future-ext 50.00% <ø> (ø)
nutype-enum 71.87% <ø> (ø)
scuffle-h264 100.00% <ø> (ø)
scuffle-http 86.21% <ø> (-0.49%) ⬇️
scuffle-metrics 87.29% <ø> (-0.58%) ⬇️
postcompile 78.81% <ø> (-1.19%) ⬇️
scuffle-pprof 100.00% <ø> (ø)
scuffle-rtmp 91.45% <94.66%> (+1.43%) ⬆️
scuffle-settings 92.85% <ø> (-0.81%) ⬇️
scuffle-signal 95.68% <ø> (+10.89%) ⬆️

scuffle-brawl bot added a commit that referenced this pull request Apr 5, 2025
feat(amf0): serde rewrite
- Rewrite scuffle-amf0 with serde support
  - Adheres to these [conventions](https://serde.rs/conventions.html)

CLOUD-91

Requested-by: lennartkloock <[email protected]>
Reviewed-by: TroyKomodo <[email protected]>
@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Apr 5, 2025

💔 Test failed - brawl-done

@lennartkloock
Copy link
Member Author

?brawl merge

Shouldn't have done a retry

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Apr 5, 2025

📌 Commit c87cefe has been approved and added to the merge queue.

Requested by: @lennartkloock

Approved by: @TroyKomodo

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Apr 5, 2025

⌛ Trying commit c87cefe with merge 9287f83...

scuffle-brawl bot added a commit that referenced this pull request Apr 5, 2025
feat(amf0): serde rewrite
- Rewrite scuffle-amf0 with serde support
  - Adheres to these [conventions](https://serde.rs/conventions.html)

CLOUD-91

Requested-by: lennartkloock <[email protected]>
Reviewed-by: TroyKomodo <[email protected]>
@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Apr 5, 2025

💔 Test failed - brawl-done

@lennartkloock
Copy link
Member Author

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Apr 5, 2025

📌 Commit 2106829 has been approved and added to the merge queue.

Requested by: @lennartkloock

Approved by: @TroyKomodo

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Apr 5, 2025

⌛ Trying commit 2106829 with merge dd6134b...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Apr 5, 2025

🎉 Build successful!
Completed in 9:40

Approved by: @TroyKomodo
Pushing dd6134b to main

@scuffle-brawl scuffle-brawl bot merged commit dd6134b into main Apr 5, 2025
15 checks passed
@scuffle-brawl scuffle-brawl bot deleted the lennart/CLOUD-91 branch April 5, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants