fix(core|manifest): Avoid error when searching non-existent 'deprecated' directory #6471
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'deprecated' directory
WalkthroughSuppresses errors when probing for a non-existent deprecated directory by adding -ErrorAction Ignore to filesystem lookups in core.ps1 and manifest.ps1; documents the change in CHANGELOG.md. No public APIs altered. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant ScoopCmd as Scoop Command
participant Core as core.ps1 (app_status)
participant FS as Filesystem
User->>ScoopCmd: info/list/update
ScoopCmd->>Core: app_status(app)
Core->>FS: Get-ChildItem deprecated/** (ErrorAction=Ignore)
alt deprecated entries found
FS-->>Core: Matches
Core-->>ScoopCmd: status with deprecated paths
else none or dir missing
FS-->>Core: No matches / suppressed errors
Core-->>ScoopCmd: status without deprecated paths
end
sequenceDiagram
autonumber
participant Cmd as Scoop Operation
participant Manifest as manifest.ps1 (Get-Manifest)
participant FS as Filesystem
Cmd->>Manifest: Get-Manifest(app)
alt manifest in bucket
Manifest->>FS: Resolve bucket manifest
FS-->>Manifest: Path
Manifest-->>Cmd: Parsed manifest
else not found
Manifest->>FS: Search deprecated/** (ErrorAction=Ignore)
alt found
FS-->>Manifest: Path
Manifest-->>Cmd: Parsed deprecated manifest
else missing
FS-->>Manifest: No matches / suppressed errors
Manifest-->>Cmd: Null/continue without error
end
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
lib/core.ps1 (1)
557-559: Good suppression; optionally guard the probe and tighten the query.Pre-checking the path avoids a needless provider error, and -File ensures only files are returned. Join-Path improves portability/readability.
- $deprecated_dir = (Find-BucketDirectory -Name $install_info.bucket -Root) + "\deprecated" - $status.deprecated = (Get-ChildItem $deprecated_dir -Filter "$(sanitary_path $app).json" -Recurse -ErrorAction Ignore).FullName + $deprecated_dir = Join-Path (Find-BucketDirectory -Name $install_info.bucket -Root) 'deprecated' + $status.deprecated = if (Test-Path $deprecated_dir) { + Get-ChildItem -Path $deprecated_dir ` + -Filter "$(sanitary_path $app).json" -Recurse -File -ErrorAction Ignore ` + | Select-Object -ExpandProperty FullName + }lib/manifest.ps1 (1)
71-73: Mirror the guard and pass a single path to parse_json.Avoids parsing with an array and skips probing when the folder is absent. Keeps error output suppressed.
- $manifest = manifest $app $bucket - if (!$manifest) { - $deprecated_dir = (Find-BucketDirectory -Name $bucket -Root) + '\deprecated' - $manifest = parse_json (Get-ChildItem $deprecated_dir -Filter "$(sanitary_path $app).json" -Recurse -ErrorAction Ignore).FullName - } + $manifest = manifest $app $bucket + if (!$manifest) { + $deprecated_dir = Join-Path (Find-BucketDirectory -Name $bucket -Root) 'deprecated' + $deprecated_manifest = if (Test-Path $deprecated_dir) { + Get-ChildItem -Path $deprecated_dir ` + -Filter "$(sanitary_path $app).json" -Recurse -File -ErrorAction Ignore ` + | Select-Object -First 1 -ExpandProperty FullName + } + $manifest = parse_json $deprecated_manifest + }If you want, I can draft a small Pester test ensuring:
- No errors are emitted when the bucket has been removed and only the deprecated lookup runs.
- Get-Manifest returns $null cleanly in that case.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)lib/core.ps1(1 hunks)lib/manifest.ps1(1 hunks)
z-Fng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
scoop-info|list|update: Error attempting to access the 'deprecated' folder in deleted bucket #6467Even though the bucket of an installed app has been removed, Scoop will still try to access the 'deprecated' folder of this bucket.
Description
This PR makes the following changes:
Checklist:
developbranch.Summary by CodeRabbit
Bug Fixes
Documentation