New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bin_match_json): check variable type before using #6150

Closed

Orion-zhen wants to merge 2 commits into ScoopInstaller:develop from Orion-zhen:fix_TryGetProperty

Orion-zhen commented Sep 20, 2024

Description

To check the type of RootElement, if it's an array, then walk through all elements inside. Or it's an object type, run the original code.

Motivation and Context

Closes #issue6140

How Has This Been Tested?

I ran my simple test in:

Windows version: 11
OS architecture: 64bit
PowerShell version: 7.4.5

Without my commit, the scoop search qqnt shows this:

With my commit, the scoop search qqnt shows this:

Displayed in one picture:

Checklist:

I have read the Contributing Guide.
I have ensured that I am targeting the develop branch.
I have updated the documentation accordingly.
I have updated the tests accordingly.
I have added an entry in the CHANGELOG.

Orion-zhen added 2 commits

September 20, 2024 21:52


          fix(bin_match_json): check type before get attribute

f039793


          making my commits verified ;-)

7531a59

Super1Windcloud commented Oct 8, 2024

@r15ch13 @niheaven @deevus @lukesampson

Member

niheaven commented Oct 10, 2024

Ref: #6151 (comment)

niheaven closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet