Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): Fix parsing error when installing multiple apps w/ specific version #6039

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Conversation

qwertyhjklxyz
Copy link
Contributor

@qwertyhjklxyz qwertyhjklxyz commented Jul 2, 2024

Description

When foreach returns only one value, the type of $specific_versions_paths is string.
When the value of $specific_versions_paths is a string, the value on the right side of the operator is appended to the string.

Motivation and Context

Closes #6038

How Has This Been Tested?

Before:

$scoop  install [email protected] firefox
...
Couldn't find manifest for 'mysql-workbench.jsonfirefox'.

After:

$scoop  install [email protected] firefox
...
Succeed!

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven changed the title fix(install): Force the result to be an array fix(install): Fix parsing error when installing multiple apps w/ specific version Jul 8, 2024
@niheaven
Copy link
Member

niheaven commented Jul 8, 2024

Please test with the new commit.

@qwertyhjklxyz
Copy link
Contributor Author

Tested and works fine.

@niheaven niheaven merged commit a76884a into ScoopInstaller:develop Jul 9, 2024
2 checks passed
@qwertyhjklxyz qwertyhjklxyz deleted the fix-add branch July 9, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants