-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chainner: Add version 0.25.1 #16984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chainner: Add version 0.25.1 #16984
Conversation
|
Warning Rate limit exceeded@scillidan has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 31 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughAdds a new Scoop package manifest file Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with Invalid manifests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @bucket/chainner.json:
- Line 6: The manifest's "suggest" field is incorrectly a string
("Versions/python311"); change the "suggest" entry to be an object mapping a
human-friendly display name to the package identifier (e.g., use a key like
"Python 3.11" mapped to "Versions/python311") so the "suggest" field is a
dictionary rather than a plain string; update the "suggest" property accordingly
in the JSON where "suggest" is defined.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/chainner.json
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
🪛 GitHub Actions: Pull Requests
bucket/chainner.json
[error] 1-1: Invalid JSON in manifest. Conversion failed for 'chainner.json'. Skipped bucket/chainner.json during manifest checks.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: WindowsPowerShell
- GitHub Check: PowerShell
🔇 Additional comments (6)
bucket/chainner.json (6)
13-18: LGTM!The shortcuts configuration is correctly formatted and creates an appropriate Start Menu entry.
19-28: LGTM! Pre-install script correctly configures Python integration.The script properly creates a default settings.json file when absent, configuring chaiNNer to use the suggested Python 3.11 installation from Scoop. The PowerShell syntax and escaping are correct.
29-29: LGTM!The persist configuration ensures user settings survive updates.
30-30: LGTM!Using GitHub as the version check source is appropriate for this repository.
7-12: Hash verified as correct.The SHA-256 hash
ab06e3a8cf036ff76440fc162539b2c4c62abee99dd452ce0bf9c313d63450edmatches the official GitHub API digest for thechaiNNer-windows-x64-0.25.1-portable.zipasset in the v0.25.1 release.
31-37: The autoupdate configuration is correct. No hash extraction is needed; when upstream providers don't expose reliable hash verification mechanisms, omitting the hash field is the standard practice across the bucket.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
/verify |
|
All changes look good. Wait for review from human collaborators. chainner
|
Closes #11395
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.