Skip to content

Conversation

@scillidan
Copy link
Contributor

@scillidan scillidan commented Jan 11, 2026

Closes #15926

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features
    • Adds support for wcap, a Windows screen-recording utility.
    • Creates a convenient shortcut for launching the app.
    • Ensures and preserves a user configuration file across installs.
    • Enables automatic update checking and binary updates for 64-bit and ARM64 systems.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 11, 2026

Walkthrough

Adds a new manifest bucket/wcap.json describing the Windows screen recording utility "wcap": metadata, dual-architecture download entries (x64 and arm64) with checksums, a shortcut, pre-install persistence handling for wcap.ini, checkver regex and autoupdate URLs.

Changes

Cohort / File(s) Summary
wcap manifest
bucket/wcap.json
New manifest for wcap v1.0.0: metadata, architecture-specific binary URLs and SHA256s, shortcuts mapping, pre_install script to ensure wcap.ini, persist entry for wcap.ini, checkver regex/replacement targeting Atom feed, and autoupdate URLs per arch.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • z-Fng
  • aliesbelik

Poem

🐰 I found a tool to catch the screen,
pixels and frames in a hopping scene.
wcap lands softly, ready to play,
recording the moments of every day. 🎥

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly reflects the primary change: adding the wcap manifest with version 20251127, matching the manifest file addition shown in the changeset.
Description check ✅ Passed The description includes the required conventional PR title checkbox and confirmation of reading the Contributing Guide, plus a reference to the related issue #15926.
Linked Issues check ✅ Passed The PR adds a wcap manifest that meets all requirements: installs the application, uses the specified download URL with proper architecture support, includes standard installation configuration, and addresses the package request criteria.
Out of Scope Changes check ✅ Passed The changes are limited to adding the bucket/wcap.json manifest file, which is directly in scope for the package request to add wcap to the repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 380458a and 33468c7.

📒 Files selected for processing (1)
  • bucket/wcap.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/wcap.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

wcap

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @bucket/wcap.json:
- Line 22: The pre_install command checks for "$persist_dir\\wcap.ini" but
creates the file at "$dir\\wcap.ini", causing the config to be written to the
temporary install dir; change the creation target to "$persist_dir\\wcap.ini" so
the New-Item call writes the wcap.ini into $persist_dir (keep the existing
Test-Path check and file name wcap.ini to ensure persistence across updates).
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0afc908 and 380458a.

📒 Files selected for processing (1)
  • bucket/wcap.json
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugviewpp.json:14-21
Timestamp: 2025-10-16T13:42:43.224Z
Learning: In the DebugViewPP project (CobaltFusion/DebugViewPP), the executable name changed from "DebugView++.exe" (in v1.8.0.103 and earlier) to "Debugviewpp.exe" (in v1.9.0.28 and later). The manifest bucket/debugviewpp.json correctly uses "Debugviewpp.exe" for current versions.
Learnt from: SorYoshino
Repo: ScoopInstaller/Extras PR: 16333
File: bucket/potplayer.json:55-64
Timestamp: 2025-10-14T11:24:17.524Z
Learning: In PotPlayer manifests (bucket/potplayer.json), the Extention folder (note the typo) is a legacy folder from older PotPlayer installers and is no longer included in newer installers. It's kept in the persist list to maintain backward compatibility with existing installations.
Learnt from: Ra2-IFV
Repo: ScoopInstaller/Extras PR: 16672
File: bucket/chromium-clang.json:12-12
Timestamp: 2025-11-29T22:02:34.868Z
Learning: In the chromium-clang.json manifest (bucket/chromium-clang.json), the extract_dir value "chrome-win32" is a fixed name determined by the upstream Chromium_Clang archive structure and should not be changed, even though the manifest targets 64-bit architecture.
Learnt from: SorYoshino
Repo: ScoopInstaller/Extras PR: 16333
File: bucket/potplayer.json:55-64
Timestamp: 2025-10-14T11:24:17.524Z
Learning: In PotPlayer manifests (bucket/potplayer.json), the Capture and Playlist folders are created at runtime (after running the application), not included in the installer, so they should only be in the persist list and not in post_install scripts.
Learnt from: SorYoshino
Repo: ScoopInstaller/Extras PR: 16333
File: bucket/potplayer.json:55-64
Timestamp: 2025-10-14T11:15:55.229Z
Learning: In PotPlayer manifests (bucket/potplayer.json), PotPlayer*.ini files (PotPlayer.ini, PotPlayer64.ini, PotPlayerMini.ini, PotPlayerMini64.ini) work correctly with Scoop's hard links and don't need special handling in post_install scripts.
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
Learnt from: SorYoshino
Repo: ScoopInstaller/Extras PR: 16333
File: bucket/potplayer.json:55-64
Timestamp: 2025-10-14T11:15:55.229Z
Learning: In PotPlayer manifests (bucket/potplayer.json), the Model and Engine folders are created at runtime (not included in the installer), so they should only be in the persist list and not in post_install scripts that handle .original directories.
📚 Learning: 2025-10-16T13:42:43.224Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugviewpp.json:14-21
Timestamp: 2025-10-16T13:42:43.224Z
Learning: In the DebugViewPP project (CobaltFusion/DebugViewPP), the executable name changed from "DebugView++.exe" (in v1.8.0.103 and earlier) to "Debugviewpp.exe" (in v1.9.0.28 and later). The manifest bucket/debugviewpp.json correctly uses "Debugviewpp.exe" for current versions.

Applied to files:

  • bucket/wcap.json
📚 Learning: 2025-09-05T09:41:52.653Z
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.

Applied to files:

  • bucket/wcap.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/wcap.json (3)

24-27: checkver configuration verified—no issues found.

The GitHub commits feed is accessible and stable, returning consistently formatted Atom XML with <updated> elements. The regex pattern correctly extracts date components from entries like 2025-11-27T04:50:14Z, and the replacement produces properly formatted YYYYMMDD versions (e.g., 20251127). Configuration is correct and functional.


8-9: Consider sourcing from GitHub Releases if available, or document the wiki URL approach.

The manifest uses wiki-based raw GitHub URLs, which is non-standard for Scoop. However, since the wcap project has no GitHub Releases and distributes binaries via wiki, this approach is technically functional and the URLs are valid. The hashes are correctly formatted SHA256 values. If the project later adds GitHub Releases, consider switching to those for better maintainability.


29-38: Hash verification in autoupdate cannot be added — upstream project does not publish checksums.

The wcap project distributes binaries via GitHub wiki without publishing checksums for new versions. Unlike standard release-based distributions, there is no mechanism to automatically scrape hashes for autoupdate. The hashes in the initial manifest are static values and cannot be dynamically obtained, similar to the CompactGUI case where hash scraping is unavailable. Hash verification in autoupdate should remain intentionally omitted until upstream publishes checksums.

Likely an incorrect or invalid review comment.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: wcap

1 participant