Skip to content

Conversation

@zeldrisho
Copy link
Contributor

@zeldrisho zeldrisho commented Jan 9, 2026

Closes #7145

scoop bucket add zeldrisho https://github.com/zeldrisho/scoop-bucket
scoop install zeldrisho/genymotion

Summary by CodeRabbit

  • New Features
    • Added Genymotion Android Emulator distribution with automatic version detection and update support, enabling users to easily stay current with the latest releases.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 9, 2026

Walkthrough

A new Scoop manifest file for Genymotion Android Emulator is added, declaring version, description, homepage, and license metadata. The manifest specifies a 64-bit installer with URL and hash verification, Windows shortcut creation, and automated version detection and update configuration.

Changes

Cohort / File(s) Change Summary
Genymotion Manifest
bucket/genymotion.json
New manifest file with metadata, architecture-specific installer configuration for 64-bit Windows builds, Inno Setup declaration, shortcut definition, and checkver/autoupdate configuration for automated version tracking

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

review-needed

Suggested reviewers

  • z-Fng

Poem

🐰 A manifest for Android dreams so bright,
With Genymotion configured just right,
No virtualbox needed here,
Version checking crystal clear,
Auto-updates hopping through the night! 🎉

🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete; it lacks the conventional PR title format and issue link details specified in the template, and does not follow the recommended format. Update the PR description to follow the conventional format '[email protected]: ' and ensure the issue reference is properly documented in the main description section.
Linked Issues check ⚠️ Warning The PR adds a Genymotion manifest for version 3.9.0, but the linked issue #7145 requests version 3.2.1; the version mismatch and absence of VirtualBox exclusion documentation present concerns. Confirm whether version 3.9.0 also installs without VirtualBox, or rebase this PR on the originally requested version 3.2.1 to meet the exact requirements from issue #7145.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'genymotion: Add version 3.9.0' is concise, specific, and clearly describes the main change of adding a new Genymotion package manifest.
Out of Scope Changes check ✅ Passed The PR only adds the genymotion.json manifest file, which is directly related to the objective of providing a Genymotion Scoop package; no out-of-scope changes detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e56aa00 and 6365140.

📒 Files selected for processing (1)
  • bucket/genymotion.json
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
📚 Learning: 2025-12-23T12:36:47.071Z
Learnt from: WordlessEcho
Repo: ScoopInstaller/Extras PR: 15764
File: bucket/peerbanhelper.json:46-59
Timestamp: 2025-12-23T12:36:47.071Z
Learning: In PeerBanHelper Scoop manifest (bucket/peerbanhelper.json), the JBR-specific batch files (gui-jbr.bat, cli-jbr.bat, etc.) that hardcode paths to intellij-jbr25 are intentional optional convenience scripts. PeerBanHelper application itself prompts warnings when not started with JBR, so hardcoded JBR paths in optional batch variants are acceptable.

Applied to files:

  • bucket/genymotion.json
📚 Learning: 2025-10-19T13:58:23.389Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.

Applied to files:

  • bucket/genymotion.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (6)
bucket/genymotion.json (6)

1-5: Metadata is correctly structured and aligned with PR objectives.

The version, license, homepage, and description fields properly reflect the Genymotion 3.9.0 release and match the linked issue requirements.


6-11: Verify installer hash and URL accessibility.

The installer configuration looks structurally correct, but the hash value and download URL should be verified to ensure they match the actual 3.9.0 release.

Please confirm:

  • The SHA-256 hash c1e21b7a353eae01aaf5495d2281d9c15fd3ad91dc404984675a6826bf7a0e96 matches the actual genymotion-3.9.0.exe binary
  • The download URL is currently accessible and serves the correct version

12-12: InnoSetup flag is appropriate.

The innosetup: true setting is correct for Genymotion's installer format.


13-18: Shortcut definition is correctly formatted.

The Windows shortcut creation is properly defined and will create an expected Start Menu entry.


19-22: Verify checkver regex against target page.

The regex pattern ([\\d.]+).exe is relatively permissive and will match any sequence of digits and dots. While this may be acceptable if the download page only contains Genymotion releases, it should be verified that the pattern reliably captures the correct version numbers without false positives.

Please confirm that the regex correctly identifies version numbers from https://genymotion.com/product-desktop/download when tested against the actual page content.


23-29: Autoupdate structure is consistent with Scoop patterns.

The URL template using $version placeholder follows standard Scoop conventions. The absence of hash verification in the autoupdate block aligns with known limitations in extracting Genymotion release hashes (similar to other projects like CompactGUI), where hash information is not available via automated scraping of release pages.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

All changes look good.

Wait for review from human collaborators.

genymotion

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Request) add genymotion-without-virtualbox

1 participant