[email protected]: Remove checkver & change download URL to Wayback Machine #16538
Conversation
…hine Updated download URLs to Wayback Machine due to homepage unavailability.
WalkthroughThe pulseview.json package manifest was updated to add a deprecation note, restructure architecture entries to reference archived URLs via Wayback Machine, and remove the checkver version checking block. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Relates to: #16379. |
|
All changes look good. Wait for review from human collaborators. pulseview
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
bucket/pulseview.json (1)
2-2: Non-standard##field usage in manifest.The
##field is not part of the official Scoop manifest schema. While it may serve as a comment-like note, this is unconventional. Consider using standard documentation practices or removing it if metadata/comments are not needed in the manifest.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/pulseview.json(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
📚 Learning: 2025-10-16T13:42:43.224Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugviewpp.json:14-21
Timestamp: 2025-10-16T13:42:43.224Z
Learning: In the DebugViewPP project (CobaltFusion/DebugViewPP), the executable name changed from "DebugView++.exe" (in v1.8.0.103 and earlier) to "Debugviewpp.exe" (in v1.9.0.28 and later). The manifest bucket/debugviewpp.json correctly uses "Debugviewpp.exe" for current versions.
Applied to files:
bucket/pulseview.json
📚 Learning: 2025-10-16T15:59:21.258Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.
Applied to files:
bucket/pulseview.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/pulseview.json (2)
9-9: Verify Wayback Machine URL format and Scoop compatibility.The URLs contain an unusual
if_parameter in the Wayback Machine timestamp section:https://web.archive.org/web/20250726225815if_/https://sigrok.org/...Please verify that:
- This is the correct Wayback Machine URL format and will resolve properly.
- Scoop's download mechanism can handle this URL format correctly.
The standard Wayback Machine format is typically
https://web.archive.org/web/[timestamp]/[url], so theif_appears non-standard.
Good news! Theif_parameter is valid. Theif_parameter is noted as "the best option" for a specific use case, and developers commonly use this parameter in Wayback Machine URLs. However, I found a caveat.Also applies to: 13-13
25-34: I need to verify the review comment claims. Let me gather information about the PulseView project and examine the manifest in context.I need to check the PR context and examine the manifest more closely:
Let me now examine the actual PR and manifest to verify the claims:
Based on my verification research, I need to provide a comprehensive assessment:
The review comment's central claim that the autoupdate URLs "point to dead URLs" is not supported by evidence. PulseView 0.4.2 provides Windows (.exe installer) builds available on the Downloads page, and the download URL exists at https://sigrok.org/download/binary/pulseview/pulseview-0.4.2-64bit-static-release-installer.exe, which matches the URL pattern in the autoupdate block. PulseView is in a usable state and has had official tarball releases, and the project remains actively maintained.
The autoupdate URLs reference a valid, functional endpoint (
sigrok.org/download/binary/pulseview/) that the upstream project currently uses for distributing Windows binaries. Unlike scenarios where versioning mechanisms are truly unavailable (as in the learned CompactGUI example where hash verification became impossible), there is no evidence that sigrok.org has stopped hosting these files or changed their distribution method.The review should be disregarded unless there is specific evidence from the PR description or testing showing that these particular URLs are actually inaccessible.
Likely an incorrect or invalid review comment.
1 participant
Changes:
Because:
Edit: Found this:
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
Documentation
Chores