Skip to content

Add UrlAfterAction into Content #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Oceania2018 merged 13 commits into from
Apr 1, 2025
Merged

Add UrlAfterAction into Content #980

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cc4e757
Add Extract Data function
Mar 27, 2025
3506179
Merge branch 'SciSharp:master' into master
evan-cao-wb Mar 27, 2025
b4c8bbd
Merge branch 'SciSharp:master' into master
evan-cao-wb Mar 28, 2025
bb7c544
Merge branch 'SciSharp:master' into master
evan-cao-wb Mar 28, 2025
8b077b4
Merge branch 'SciSharp:master' into master
evan-cao-wb Mar 30, 2025
4c302b6
Add Page Url
Mar 31, 2025
f5bd6a9
Merge branch 'master' of https://github.com/evan-cao-wb/BotSharp
Mar 31, 2025
03a6f85
Merge branch 'SciSharp:master' into master
evan-cao-wb Mar 31, 2025
d0b4a49
Merge branch 'master' of https://github.com/evan-cao-wb/BotSharp
Mar 31, 2025
d2bba95
Revert all changes
Apr 1, 2025
994d6df
Merge branch 'SciSharp:master' into master
evan-cao-wb Apr 1, 2025
0164cc5
Merge branch 'SciSharp:master' into master
evan-cao-wb Apr 1, 2025
2a322f6
add show_current_url = true
Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Plugins/BotSharp.Plugin.WebDriver/BotSharp.Plugin.WebDriver.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>$(TargetFramework)</TargetFramework>
Expand Down
2 changes: 1 addition & 1 deletion src/Plugins/BotSharp.Plugin.WebDriver/UtilFunctions/UtilWebActionOnElementFn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public async Task<bool> Execute(RoleDialogModel message)
};
var result = await browser.ActionOnElement(msg, locatorArgs, actionArgs);

message.Content = $"{actionArgs.Action} executed {(result.IsSuccess ? "success" : "failed")}";
message.Content = $"{actionArgs.Action} executed {(result.IsSuccess ? "success" : "failed")}. Current page url: '{result.UrlAfterAction}'.";
Copy link
Member

@Oceania2018 Oceania2018 Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if args.show_current_url:
message.Content += "\r\nCurrent page url: '{result.UrlAfterAction}".


var path = webDriverService.GetScreenshotFilePath(message.MessageId);

Expand Down
Loading