Improve static analysis: add JET tests and fix undefined variable issues #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Add JET.jl to test dependencies with tests for algorithm constructors - Add getindex method for UserFunctionAndData to support userfun[] syntax - Add else error branch in cvode! for unrecognized integrator type - Add else error branch in CVODE __init for unrecognized algorithm type - Add else error branch in KINSOL solve for unrecognized function types These changes address several JET.jl static analysis warnings: - MethodErrorReport for getindex on UserFunctionAndData - UndefVarErrorReport for mem_ptr in cvode! with unknown integrator - UndefVarErrorReport for alg_code in __init with unknown algorithm - UndefVarErrorReport for f! with unsupported function types 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves static analysis compatibility by adding JET.jl tests and fixing several issues identified during JET analysis.
Changes
JET.jl Integration:
Bug Fixes (addressing JET warnings):
getindexmethod forUserFunctionAndDatato supportuserfun[]syntax used inkinsolfuncvode!for unrecognized integrator type (was undefined variable)__initfor unrecognized algorithm type (was undefined variable)JET Issues Addressed
The following JET reports are now handled:
MethodErrorReportforgetindex(::UserFunctionAndData)UndefVarErrorReportformem_ptrincvode!with unknown integratorUndefVarErrorReportforalg_codein__initwith unknown algorithmUndefVarErrorReportforf!with unsupported function typesTest Results
All tests pass including the new JET tests:
Test plan
Pkg.test()to verify all existing tests passcc @ChrisRackauckas
🤖 Generated with Claude Code