Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a wrapper for Optimization.jl #395

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Mar 26, 2024

Unfortunately, this introduces a massive circular dependency if Optimization is loaded. But we only pay the price in CI rn.

@avik-pal avik-pal force-pushed the ap/opt branch 2 times, most recently from b898160 to 94cab9c Compare March 26, 2024 21:25
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 93.47826% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.63%. Comparing base (b7ba71d) to head (3617d6f).

Files Patch % Lines
ext/NonlinearSolveOptimizationExt.jl 95.23% 2 Missing ⚠️
src/algorithms/extension_algs.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   81.16%   80.63%   -0.54%     
==========================================
  Files          46       47       +1     
  Lines        2804     2850      +46     
==========================================
+ Hits         2276     2298      +22     
- Misses        528      552      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Why not just add this code to OptmizationBase and document it here?

@avik-pal
Copy link
Member Author

That's probably a better way I will do that

@avik-pal avik-pal marked this pull request as draft March 27, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants