Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structs for NeuralOperators #23

Merged
merged 16 commits into from
Aug 20, 2024
Merged

Structs for NeuralOperators #23

merged 16 commits into from
Aug 20, 2024

Conversation

ayushinav
Copy link
Contributor

fixes #19

@ayushinav
Copy link
Contributor Author

@avik-pal
I'm not able to run tests, and always get the error
InitError: KeyError: key "JULIA_AMDGPU_CORE_MUST_LOAD" not found
I commented AMDGPU mode out from MODES in sharedtestsetup.jl

Copy link
Member

@avik-pal avik-pal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failures suggest that there are type instabilities

src/deeponet.jl Outdated Show resolved Hide resolved
src/fno.jl Outdated Show resolved Hide resolved
src/fno.jl Outdated Show resolved Hide resolved
src/deeponet.jl Outdated Show resolved Hide resolved
src/deeponet.jl Outdated Show resolved Hide resolved
src/layers.jl Outdated Show resolved Hide resolved
src/deeponet.jl Outdated Show resolved Hide resolved
@avik-pal
Copy link
Member

@avik-pal I'm not able to run tests, and always get the error InitError: KeyError: key "JULIA_AMDGPU_CORE_MUST_LOAD" not found I commented AMDGPU mode out from MODES in sharedtestsetup.jl

If you are running the tests locally, set the BACKEND_GROUP environment variable to CPU/CUDA/AMDGPU to run specific subsets fo the tests.

@avik-pal avik-pal force-pushed the fixes branch 3 times, most recently from 298a078 to 7c8d9a1 Compare August 20, 2024 01:16
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.78%. Comparing base (2f2de89) to head (a0c8310).
Report is 1 commits behind head on main.

Files Patch % Lines
src/layers.jl 88.88% 1 Missing ⚠️
src/utils.jl 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   94.89%   94.78%   -0.12%     
==========================================
  Files           7        7              
  Lines          98      115      +17     
==========================================
+ Hits           93      109      +16     
- Misses          5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal merged commit e248a56 into SciML:main Aug 20, 2024
14 of 15 checks passed
@ayushinav ayushinav deleted the fixes branch August 21, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants